CADC-13596 Addressed requests #90
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
=======================================
Coverage ? 12.89%
Complexity ? 11
=======================================
Files ? 12
Lines ? 318
Branches ? 30
=======================================
Hits ? 41
Misses ? 273
Partials ? 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| [DESKTOP_TYPE]: DEFAULT_DESKTOP_SKAHA_IMAGE, | ||
| [NOTEBOOK_TYPE]: DEFAULT_NOTEBOOK_SKAHA_IMAGE, | ||
|
|
||
| } |
There was a problem hiding this comment.
We're incurring some technical debt here as the defaults are all hard-coded. The default number of cores and memory is fine, but the default Images could be removed or added to/from the Harbor repository, which means re-releasing the Science Portal each time. Oh well, we'll live with it for now.
There was a problem hiding this comment.
Agree, but I did not find a better way to target a requested image. However, if something changed, we still can relay on the first image in the sorted list
There was a problem hiding this comment.
In addition, a decoupled version of the front-end will be easily (and fast) deployable
No description provided.